Compare commits

..

6 Commits

Author SHA1 Message Date
Anton
83bc603b95 feat: /meta для версии в футере и устойчивый разбор JSON
Some checks failed
CI / build-and-test (pull_request) Has been cancelled
2026-04-08 10:32:52 +03:00
f8b4ce7111 Merge pull request 'fix(api): дублировать маршруты под /api и убрать Content-Type у GET' (#16) from fix/api-prefix-routing into main
Some checks failed
CI / build-and-test (push) Has been cancelled
Reviewed-on: #16
2026-04-08 07:21:03 +00:00
Anton
53b9561a54 fix(api): дублировать маршруты под /api и убрать Content-Type у GET
Some checks failed
CI / build-and-test (pull_request) Has been cancelled
2026-04-08 10:20:17 +03:00
7e9c20d4bf Merge pull request 'fix: прод — CORS, версия API, ошибки клиента и подсказка по прошедшим стартам' (#15) from fix/prod-cors-health-status-hints into main
Some checks failed
CI / build-and-test (push) Has been cancelled
Reviewed-on: #15
2026-04-07 22:21:49 +00:00
Vaka.pro
e0ed0b6435 fix: прод — CORS, версия API, ошибки клиента и подсказка по прошедшим стартам
Some checks failed
CI / build-and-test (pull_request) Has been cancelled
- CORS_ORIGIN: несколько origin через запятую; комментарии в .env.example
- Версия бэкенда: APP_VERSION, безопасное чтение package.json, футер при пустой версии
- Сообщения API: unknown_error и ответы 401/403/404 без JSON; отладочный лог при !ok
- Статус «внесите результат» для прошедшей даты + блок на карточке старта и стили
2026-04-08 01:21:11 +03:00
8442c761c2 Merge pull request 'fix(frontend): bundle app version via package.json import instead of Vite define' (#14) from fix/vite-frontend-version-define into main
Some checks failed
CI / build-and-test (push) Has been cancelled
Reviewed-on: #14
2026-04-07 21:55:25 +00:00
18 changed files with 205 additions and 36 deletions

View File

@@ -24,10 +24,16 @@ API_PORT=3001
# CALENDAR_RUN_MOCK_DB=1 # CALENDAR_RUN_MOCK_DB=1
# ─── CORS ──────────────────────────────────────────────────── # ─── CORS ────────────────────────────────────────────────────
# Должен совпадать с origin в браузере (схема + хост + порт, без пути), иначе API «молчит».
# Локальный Vite: http://localhost:5173 # Локальный Vite: http://localhost:5173
# Стек с фронтом на 3033: http://localhost:3033 # Стек с фронтом на 3033: http://localhost:3033
# Прод: https://ваш-домен — несколько origin через запятую: https://a.ru,https://www.a.ru
CORS_ORIGIN=http://localhost:5173 CORS_ORIGIN=http://localhost:5173
# ─── Версия API (опционально) ─────────────────────────────────
# Если в образе не удаётся прочитать package.json, подставьте вручную (видно в GET /health).
# APP_VERSION=1.0.0
# ─── Frontend (Vite, локально из каталога frontend/) ───────── # ─── Frontend (Vite, локально из каталога frontend/) ─────────
# В Docker-образе фронта базовый URL API задаётся при сборке (/api), не из .env. # В Docker-образе фронта базовый URL API задаётся при сборке (/api), не из .env.
VITE_API_BASE_URL=http://localhost:3001 VITE_API_BASE_URL=http://localhost:3001

View File

@@ -1,6 +1,6 @@
{ {
"name": "calendar-run-backend", "name": "calendar-run-backend",
"version": "1.0.0", "version": "1.1.0",
"private": true, "private": true,
"scripts": { "scripts": {
"build": "tsc", "build": "tsc",

View File

@@ -7,11 +7,16 @@ import racesRouter from "./routes/races";
export function createApp(): express.Express { export function createApp(): express.Express {
const app = express(); const app = express();
app.use(cors({ origin: config.corsOrigin, methods: ["GET", "POST", "PATCH", "DELETE"] })); app.use(
cors({ origin: config.corsOrigin, methods: ["GET", "POST", "PATCH", "DELETE", "OPTIONS"] }),
);
app.use(express.json()); app.use(express.json());
app.use(healthRouter); app.use(healthRouter);
app.use(racesRouter); app.use(racesRouter);
// Тот же API под /api/* — если прокси не снимает префикс или запрос идёт напрямую на порт бэкенда с /api.
app.use("/api", healthRouter);
app.use("/api", racesRouter);
app.use((err: unknown, _req: Request, res: Response, _next: NextFunction) => { app.use((err: unknown, _req: Request, res: Response, _next: NextFunction) => {
if (err instanceof SyntaxError && "body" in err) { if (err instanceof SyntaxError && "body" in err) {

View File

@@ -33,5 +33,21 @@ export const config = {
password: requireEnv("DB_PASSWORD"), password: requireEnv("DB_PASSWORD"),
}, },
apiPort: parseInt(process.env.PORT || process.env.API_PORT || "3001", 10), apiPort: parseInt(process.env.PORT || process.env.API_PORT || "3001", 10),
corsOrigin: process.env.CORS_ORIGIN || "http://localhost:5173", /** Одно значение или несколько через запятую (прод: https://домен) */
corsOrigin: parseCorsOrigins(),
}; };
function parseCorsOrigins(): string | string[] {
const raw = process.env.CORS_ORIGIN?.trim();
if (!raw) {
return "http://localhost:5173";
}
const parts = raw.split(",").map((s) => s.trim()).filter(Boolean);
if (parts.length === 0) {
return "http://localhost:5173";
}
if (parts.length === 1) {
return parts[0]!;
}
return parts;
}

View File

@@ -8,6 +8,11 @@ router.get("/health", (_req: Request, res: Response) => {
res.json({ status: "ok", version: getBackendVersion() }); res.json({ status: "ok", version: getBackendVersion() });
}); });
/** Версия для UI; путь без «health», чтобы реже резался фильтрами/прокси. */
router.get("/meta", (_req: Request, res: Response) => {
res.json({ version: getBackendVersion() });
});
router.get("/ready", async (_req: Request, res: Response) => { router.get("/ready", async (_req: Request, res: Response) => {
const dbOk = await checkDbConnection(); const dbOk = await checkDbConnection();
if (dbOk) { if (dbOk) {

View File

@@ -7,8 +7,18 @@ export function getBackendVersion(): string {
if (cached) { if (cached) {
return cached; return cached;
} }
const pkgPath = path.join(__dirname, "..", "package.json"); const fromEnv = process.env.APP_VERSION?.trim();
const raw = fs.readFileSync(pkgPath, "utf-8"); if (fromEnv) {
cached = (JSON.parse(raw) as { version: string }).version; cached = fromEnv;
return cached; return cached;
}
try {
const pkgPath = path.join(__dirname, "..", "package.json");
const raw = fs.readFileSync(pkgPath, "utf-8");
cached = (JSON.parse(raw) as { version: string }).version;
return cached;
} catch {
cached = "0.0.0";
return cached;
}
} }

View File

@@ -12,6 +12,23 @@ test("GET /health returns ok", async () => {
assert.ok(res.body.version.length > 0); assert.ok(res.body.version.length > 0);
}); });
test("GET /api/health returns ok (prefix without proxy strip)", async () => {
const res = await request(app).get("/api/health").expect(200);
assert.equal(res.body.status, "ok");
});
test("GET /meta returns version for UI footer", async () => {
const res = await request(app).get("/meta").expect(200);
assert.equal(typeof res.body.version, "string");
assert.ok(res.body.version.length > 0);
});
test("GET /api/meta mirrors GET /meta", async () => {
const res = await request(app).get("/api/meta").expect(200);
assert.equal(typeof res.body.version, "string");
assert.ok(res.body.version.length > 0);
});
test("GET /ready succeeds with mock database", async () => { test("GET /ready succeeds with mock database", async () => {
const res = await request(app).get("/ready").expect(200); const res = await request(app).get("/ready").expect(200);
assert.equal(res.body.status, "ready"); assert.equal(res.body.status, "ready");
@@ -34,6 +51,11 @@ test("GET /races accepts year and month", async () => {
assert.ok(Array.isArray(res.body)); assert.ok(Array.isArray(res.body));
}); });
test("GET /api/races mirrors GET /races", async () => {
const res = await request(app).get("/api/races?year=2026&month=5").expect(200);
assert.ok(Array.isArray(res.body));
});
test("GET /races/:id returns not_found", async () => { test("GET /races/:id returns not_found", async () => {
const res = await request(app).get("/races/does-not-exist").expect(404); const res = await request(app).get("/races/does-not-exist").expect(404);
assert.equal(res.body.error, "not_found"); assert.equal(res.body.error, "not_found");

View File

@@ -1,7 +1,7 @@
{ {
"name": "calendar-run-frontend", "name": "calendar-run-frontend",
"private": true, "private": true,
"version": "0.1.0", "version": "0.2.0",
"type": "module", "type": "module",
"scripts": { "scripts": {
"dev": "vite", "dev": "vite",

View File

@@ -35,7 +35,8 @@ function normalizeApiCode(value: string | undefined): ApiErrorCode {
value === "validation_error" || value === "validation_error" ||
value === "not_found" || value === "not_found" ||
value === "database_unavailable" || value === "database_unavailable" ||
value === "conflict" value === "conflict" ||
value === "unknown_error"
) { ) {
return value; return value;
} }
@@ -62,6 +63,17 @@ export function toApiError(status: number, payload: unknown): ApiError {
}); });
} }
if (!hasStructuredApiError(payload) && (status === 401 || status === 403 || status === 404)) {
return new ApiError({
code: "network_error",
status,
message:
status === 404
? "API не найден по этому адресу. Проверьте прокси и префикс /api."
: "Запрос отклонён сервером. Проверьте переменную CORS_ORIGIN на бэкенде.",
});
}
const maybePayload = payload as ApiErrorPayload; const maybePayload = payload as ApiErrorPayload;
const code = normalizeApiCode(maybePayload?.error); const code = normalizeApiCode(maybePayload?.error);
const details = Array.isArray(maybePayload?.details) const details = Array.isArray(maybePayload?.details)
@@ -88,6 +100,8 @@ export function getApiErrorMessage(code: ApiErrorCode): string {
return "Запись с таким идентификатором уже существует."; return "Запись с таким идентификатором уже существует.";
case "network_error": case "network_error":
return "Не удалось связаться с сервером."; return "Не удалось связаться с сервером.";
case "unknown_error":
return "Сервер не смог обработать запрос. Попробуйте позже или обновите страницу.";
default: default:
return "Произошла неизвестная ошибка."; return "Произошла неизвестная ошибка.";
} }

View File

@@ -5,6 +5,15 @@ export type HealthResponse = {
version: string; version: string;
}; };
export type BackendMetaResponse = {
version: string;
};
export async function getHealth(init?: RequestInit): Promise<HealthResponse> { export async function getHealth(init?: RequestInit): Promise<HealthResponse> {
return requestJson<HealthResponse>("/health", init); return requestJson<HealthResponse>("/health", init);
} }
/** Версия бэкенда для футера (отдельный путь от /health — меньше ложных блокировок). */
export async function getBackendMeta(init?: RequestInit): Promise<BackendMetaResponse> {
return requestJson<BackendMetaResponse>("/meta", init);
}

View File

@@ -8,16 +8,30 @@ function buildUrl(path: string): string {
} }
async function parseResponseBody(response: Response): Promise<unknown> { async function parseResponseBody(response: Response): Promise<unknown> {
const contentType = response.headers.get("content-type") ?? ""; const text = await response.text();
if (!contentType.includes("application/json")) { if (!text.trim()) {
return null; return null;
} }
try { const contentType = response.headers.get("content-type") ?? "";
return await response.json(); if (contentType.includes("application/json")) {
} catch { try {
return null; return JSON.parse(text) as unknown;
} catch {
return null;
}
} }
const trimmed = text.trim();
if (trimmed.startsWith("{") || trimmed.startsWith("[")) {
try {
return JSON.parse(text) as unknown;
} catch {
return null;
}
}
return null;
} }
const GATEWAY_RETRY_STATUSES = new Set([502, 503, 504]); const GATEWAY_RETRY_STATUSES = new Set([502, 503, 504]);
@@ -35,10 +49,15 @@ export async function requestJson<T>(path: string, init?: RequestInit): Promise<
for (let attempt = 1; attempt <= maxAttempts; attempt += 1) { for (let attempt = 1; attempt <= maxAttempts; attempt += 1) {
try { try {
const defaultHeaders: Record<string, string> = {};
if (method !== "GET" && method !== "HEAD") {
defaultHeaders["Content-Type"] = "application/json";
}
const response = await fetch(buildUrl(path), { const response = await fetch(buildUrl(path), {
...init, ...init,
headers: { headers: {
"Content-Type": "application/json", ...defaultHeaders,
...(init?.headers ?? {}), ...(init?.headers ?? {}),
}, },
}); });

View File

@@ -1,5 +1,5 @@
export type { CreateRacePayload, Race, RacesQuery, RaceStatus, UpdateRacePayload } from "./types"; export type { CreateRacePayload, Race, RacesQuery, RaceStatus, UpdateRacePayload } from "./types";
export { ApiError, getApiErrorMessage } from "./errors"; export { ApiError, getApiErrorMessage } from "./errors";
export type { HealthResponse } from "./health"; export type { BackendMetaResponse, HealthResponse } from "./health";
export { getHealth } from "./health"; export { getBackendMeta, getHealth } from "./health";
export { getRaceById, getRaces, createRace, updateRace, deleteRace } from "./races"; export { getRaceById, getRaces, createRace, updateRace, deleteRace } from "./races";

View File

@@ -1,21 +1,29 @@
import { useEffect, useState } from "react"; import { useEffect, useState } from "react";
import { getHealth } from "../../api"; import { getBackendMeta } from "../../api";
import { FRONTEND_VERSION } from "../../frontendVersion"; import { FRONTEND_VERSION } from "../../frontendVersion";
function isAbortError(error: unknown): boolean {
return (
(error instanceof DOMException && error.name === "AbortError") ||
(error instanceof Error && error.name === "AbortError")
);
}
export function AppShellFooter(): JSX.Element { export function AppShellFooter(): JSX.Element {
const [backendVersion, setBackendVersion] = useState<string | null>(null); const [backendVersion, setBackendVersion] = useState<string | null>(null);
useEffect(() => { useEffect(() => {
const ac = new AbortController(); const ac = new AbortController();
void getHealth({ signal: ac.signal }) void getBackendMeta({ signal: ac.signal })
.then((h) => { .then((meta) => {
if (ac.signal.aborted) { if (ac.signal.aborted) {
return; return;
} }
setBackendVersion(h.version); const v = meta.version;
setBackendVersion(typeof v === "string" && v.length > 0 ? v : "не указана");
}) })
.catch(() => { .catch((err) => {
if (ac.signal.aborted) { if (ac.signal.aborted || isAbortError(err)) {
return; return;
} }
setBackendVersion("недоступна"); setBackendVersion("недоступна");

View File

@@ -8,6 +8,7 @@ export {
isCloseDistance, isCloseDistance,
parseFinishTimeToSeconds, parseFinishTimeToSeconds,
parseRaceDate, parseRaceDate,
raceNeedsResultEntry,
sortByDateAsc, sortByDateAsc,
sortByDateDesc, sortByDateDesc,
splitRacesByDate, splitRacesByDate,

View File

@@ -122,18 +122,36 @@ export function getPaceLabel(finishTime: string | null, distanceKm: number): str
return `${String(paceMinutes).padStart(2, "0")}:${String(paceRemainder).padStart(2, "0")} /км`; return `${String(paceMinutes).padStart(2, "0")}:${String(paceRemainder).padStart(2, "0")} /км`;
} }
export function getRaceStatusClassName(status: Race["status"]): string { function isPastDateNeedingResult(status: Race["status"], raceDate: string): boolean {
const base = "race-card__status"; if (status !== "planned" && status !== "registered") {
if (status === "completed") { return false;
return `${base} ${base}--completed`;
} }
if (status === "registered") { const today = new Date();
return `${base} ${base}--registered`; today.setHours(0, 0, 0, 0);
} return parseRaceDate(raceDate).getTime() < today.getTime();
return `${base} ${base}--planned`;
} }
export function getRaceStatusLabel(status: Race["status"]): string { export function raceNeedsResultEntry(race: Race): boolean {
return isPastDateNeedingResult(race.status, race.date);
}
export function getRaceStatusClassName(status: Race["status"], raceDate?: string): string {
const base = "race-card__status";
let tier = `${base}--planned`;
if (status === "completed") {
tier = `${base}--completed`;
} else if (status === "registered") {
tier = `${base}--registered`;
}
const needs =
raceDate && isPastDateNeedingResult(status, raceDate) ? ` ${base}--needs-result` : "";
return `${base} ${tier}${needs}`;
}
export function getRaceStatusLabel(status: Race["status"], raceDate?: string): string {
if (raceDate && isPastDateNeedingResult(status, raceDate)) {
return "внесите результат";
}
if (status === "completed") { if (status === "completed") {
return "пробежал"; return "пробежал";
} }

View File

@@ -7,6 +7,7 @@ import {
getPaceLabel, getPaceLabel,
getRaceStatusClassName, getRaceStatusClassName,
getRaceStatusLabel, getRaceStatusLabel,
raceNeedsResultEntry,
} from "../lib"; } from "../lib";
import type { Race } from "../api"; import type { Race } from "../api";
@@ -148,9 +149,19 @@ export function RaceDetailsPage(): JSX.Element {
{formatRaceDate(race.date)} · {formatDistance(race.distanceKm)} {formatRaceDate(race.date)} · {formatDistance(race.distanceKm)}
</p> </p>
</div> </div>
<span className={getRaceStatusClassName(race.status)}>{getRaceStatusLabel(race.status)}</span> <span className={getRaceStatusClassName(race.status, race.date)}>{getRaceStatusLabel(race.status, race.date)}</span>
</div> </div>
{raceNeedsResultEntry(race) ? (
<p className="race-details-past-hint" role="status">
Дата старта уже прошла {" "}
<Link className="race-details-past-hint__link" to={`/races/${race.id}/edit`}>
внесите результат или обновите статус
</Link>
.
</p>
) : null}
<div className="race-details-actions"> <div className="race-details-actions">
<Link className="btn btn--primary" to={`/races/${race.id}/edit`}> <Link className="btn btn--primary" to={`/races/${race.id}/edit`}>
Редактировать Редактировать
@@ -202,7 +213,7 @@ export function RaceDetailsPage(): JSX.Element {
</div> </div>
<div className="race-details-meta__item"> <div className="race-details-meta__item">
<dt className="race-details-meta__key">Статус</dt> <dt className="race-details-meta__key">Статус</dt>
<dd className="race-details-meta__value">{getRaceStatusLabel(race.status)}</dd> <dd className="race-details-meta__value">{getRaceStatusLabel(race.status, race.date)}</dd>
</div> </div>
<DetailLink label="Сайт организатора" url={race.officialUrl} /> <DetailLink label="Сайт организатора" url={race.officialUrl} />
<DetailItem label="Время старта" value={race.startTime} /> <DetailItem label="Время старта" value={race.startTime} />

View File

@@ -64,7 +64,7 @@ function RaceList(props: { title: string; races: Race[] }): JSX.Element {
{formatRaceDate(race.date)} · {formatDistance(race.distanceKm)} {formatRaceDate(race.date)} · {formatDistance(race.distanceKm)}
</p> </p>
</div> </div>
<span className={getRaceStatusClassName(race.status)}>{getRaceStatusLabel(race.status)}</span> <span className={getRaceStatusClassName(race.status, race.date)}>{getRaceStatusLabel(race.status, race.date)}</span>
</li> </li>
))} ))}
</ul> </ul>

View File

@@ -291,6 +291,31 @@ a {
color: #8a5a00; color: #8a5a00;
} }
.race-card__status--needs-result {
outline: 1px solid var(--color-warning);
}
.race-details-past-hint {
margin: 0 0 var(--space-4);
padding: var(--space-3) var(--space-4);
border-radius: var(--radius-md);
border: 1px solid var(--color-warning);
background: #fffaf0;
color: var(--color-text);
font-size: var(--font-size-caption);
}
.race-details-past-hint__link {
color: var(--color-accent);
font-weight: 600;
text-decoration: underline;
}
.race-details-past-hint__link:hover,
.race-details-past-hint__link:focus-visible {
outline: none;
}
.races-filter { .races-filter {
margin-top: var(--space-5); margin-top: var(--space-5);
display: flex; display: flex;