fix: avoid Jinja dict items collision in employee card #6
@@ -110,4 +110,4 @@ docker compose exec postgres pg_dump -U miem miem_workers > backup.sql
|
|||||||
docker compose down
|
docker compose down
|
||||||
```
|
```
|
||||||
|
|
||||||
Версия сервиса: `0.2.3`. Админка всегда показывает версии backend и frontend в footer.
|
Версия сервиса: `0.2.4`. Админка всегда показывает версии backend и frontend в footer.
|
||||||
|
|||||||
@@ -59,7 +59,7 @@ def employee_detail_payload(employee: Employee) -> dict[str, Any]:
|
|||||||
"emails": _clean_list(contacts.get("emails")),
|
"emails": _clean_list(contacts.get("emails")),
|
||||||
"phones": _clean_list(contacts.get("phones")),
|
"phones": _clean_list(contacts.get("phones")),
|
||||||
"address": contacts.get("address"),
|
"address": contacts.get("address"),
|
||||||
"items": _normalize_contact_items(contacts.get("items")),
|
"contact_items": _normalize_contact_items(contacts.get("items")),
|
||||||
},
|
},
|
||||||
"external_ids": _normalize_external_ids(data.get("external_ids")),
|
"external_ids": _normalize_external_ids(data.get("external_ids")),
|
||||||
"sections": [_normalize_section(section) for section in _as_list(data.get("sections"))],
|
"sections": [_normalize_section(section) for section in _as_list(data.get("sections"))],
|
||||||
|
|||||||
@@ -62,12 +62,12 @@
|
|||||||
<dt class="employee-card__meta-label">Адрес</dt>
|
<dt class="employee-card__meta-label">Адрес</dt>
|
||||||
<dd class="employee-card__meta-value">{{ employee_view.contacts.address or "Не указано" }}</dd>
|
<dd class="employee-card__meta-value">{{ employee_view.contacts.address or "Не указано" }}</dd>
|
||||||
</div>
|
</div>
|
||||||
{% if employee_view.contacts.items %}
|
{% if employee_view.contacts.contact_items %}
|
||||||
<div class="employee-card__meta-item employee-card__meta-item--wide">
|
<div class="employee-card__meta-item employee-card__meta-item--wide">
|
||||||
<dt class="employee-card__meta-label">Прочее</dt>
|
<dt class="employee-card__meta-label">Прочее</dt>
|
||||||
<dd class="employee-card__meta-value">
|
<dd class="employee-card__meta-value">
|
||||||
<ul class="employee-card__list">
|
<ul class="employee-card__list">
|
||||||
{% for item in employee_view.contacts.items %}
|
{% for item in employee_view.contacts.contact_items %}
|
||||||
<li class="employee-card__list-item">{{ item }}</li>
|
<li class="employee-card__list-item">{{ item }}</li>
|
||||||
{% endfor %}
|
{% endfor %}
|
||||||
</ul>
|
</ul>
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
APP_VERSION = "0.2.3"
|
APP_VERSION = "0.2.4"
|
||||||
FRONTEND_VERSION = "0.2.3"
|
FRONTEND_VERSION = "0.2.4"
|
||||||
BACKEND_VERSION = "0.2.3"
|
BACKEND_VERSION = "0.2.4"
|
||||||
|
|||||||
@@ -86,7 +86,7 @@ def test_employee_detail_payload_normalizes_human_readable_sections(db_session):
|
|||||||
payload = employee_detail_payload(employee)
|
payload = employee_detail_payload(employee)
|
||||||
|
|
||||||
assert payload["contacts"]["emails"] == ["person@hse.ru"]
|
assert payload["contacts"]["emails"] == ["person@hse.ru"]
|
||||||
assert payload["contacts"]["items"] == ["consultation hours"]
|
assert payload["contacts"]["contact_items"] == ["consultation hours"]
|
||||||
assert payload["external_ids"][0]["system"] == "ORCID"
|
assert payload["external_ids"][0]["system"] == "ORCID"
|
||||||
assert payload["sections"][0]["year_entries"][0]["text"] == "Master degree"
|
assert payload["sections"][0]["year_entries"][0]["text"] == "Master degree"
|
||||||
assert payload["sections"][1]["publications"][0]["title"] == "Paper"
|
assert payload["sections"][1]["publications"][0]["title"] == "Paper"
|
||||||
@@ -111,6 +111,7 @@ def test_employee_payloads_tolerate_malformed_current_data(db_session):
|
|||||||
assert display["positions"] == []
|
assert display["positions"] == []
|
||||||
assert display["email_text"] == ""
|
assert display["email_text"] == ""
|
||||||
assert detail["contacts"]["emails"] == []
|
assert detail["contacts"]["emails"] == []
|
||||||
|
assert detail["contacts"]["contact_items"] == []
|
||||||
assert detail["sections"] == []
|
assert detail["sections"] == []
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
@@ -18,7 +18,7 @@ def test_health_returns_versions():
|
|||||||
response = client.get("/api/health")
|
response = client.get("/api/health")
|
||||||
|
|
||||||
assert response.status_code == 200
|
assert response.status_code == 200
|
||||||
assert response.json()["backend_version"] == "0.2.3"
|
assert response.json()["backend_version"] == "0.2.4"
|
||||||
|
|
||||||
|
|
||||||
def test_mcp_requires_token_and_lists_tools():
|
def test_mcp_requires_token_and_lists_tools():
|
||||||
|
|||||||
@@ -7,6 +7,8 @@ def test_employee_detail_template_is_human_readable():
|
|||||||
assert "Current data" not in template
|
assert "Current data" not in template
|
||||||
assert "<pre class=\"code\"" not in template
|
assert "<pre class=\"code\"" not in template
|
||||||
assert ">Tabs<" not in template
|
assert ">Tabs<" not in template
|
||||||
|
assert "contacts.items" not in template
|
||||||
|
assert "contacts.contact_items" in template
|
||||||
assert "Основная информация" in template
|
assert "Основная информация" in template
|
||||||
assert "Контакты" in template
|
assert "Контакты" in template
|
||||||
assert "Разделы профиля" in template
|
assert "Разделы профиля" in template
|
||||||
|
|||||||
Reference in New Issue
Block a user