175 lines
11 KiB
Python
175 lines
11 KiB
Python
import tempfile
|
|
import unittest
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
from search.api import Api, ApiError, SEARCH_ALGORITHM_VERSION
|
|
|
|
|
|
class SearchReviewTest(unittest.TestCase):
|
|
def test_multi_index_snapshot_and_saved_review_preserve_configured_scope(self):
|
|
with tempfile.TemporaryDirectory() as temporary:
|
|
api = Api("http://opensearch:9200", "A,B", Path(temporary), Path(temporary) / "reviews.sqlite3", b"test-secret")
|
|
cases = (
|
|
("no hits", []),
|
|
("A only", [{"_index": "A", "_source": {"document_code": "7", "document_name_ru": "Закон A"}}]),
|
|
("B only", [{"_index": "B", "_source": {"document_code": "8", "document_name_ru": "Закон B"}}]),
|
|
("mixed", [
|
|
{"_index": "A", "_source": {"document_code": "7", "document_name_ru": "Закон A"}},
|
|
{"_index": "B", "_source": {"document_code": "8", "document_name_ru": "Закон B"}},
|
|
]),
|
|
)
|
|
for label, hits in cases:
|
|
with self.subTest(case=label):
|
|
with patch("search.api.request_json", return_value={"hits": {"hits": hits}}):
|
|
result = api.handle("GET", "/search?q=test&language=ru")[1]
|
|
token = result["review_token"]
|
|
self.assertEqual(api.review_snapshots.verify(token)["index_name"], "A,B")
|
|
review_results = [
|
|
{"rank": rank, "code": item["code"], "rating": 3}
|
|
for rank, item in enumerate(result["results"], 1)
|
|
]
|
|
api.handle("POST", "/search-reviews", {
|
|
"review_token": token,
|
|
"reviewer": "Юрист",
|
|
"results": review_results,
|
|
"overall_comment": "Проверена выдача для настроенного scope.",
|
|
})
|
|
saved = api.handle("GET", "/search-reviews/export")[1]["reviews"][-1]
|
|
self.assertEqual(saved["index_name"], "A,B")
|
|
|
|
def test_review_must_cover_each_snapshot_rank_once(self):
|
|
with tempfile.TemporaryDirectory() as temporary:
|
|
api = Api("http://opensearch:9200", "current", Path(temporary), Path(temporary) / "reviews.sqlite3", b"test-secret")
|
|
response = {"hits": {"hits": [{"_index": "search-20260827", "_source": {"document_code": "7", "edition_code": "10", "document_name_ru": "Закон"}}, {"_index": "search-20260827", "_source": {"document_code": "8", "edition_code": "11", "document_name_ru": "Кодекс"}}]}}
|
|
with patch("search.api.request_json", return_value=response):
|
|
result = api.handle("GET", "/search?q=test&language=ru&page_size=2")[1]
|
|
with self.assertRaisesRegex(ApiError, "exactly once"):
|
|
api.handle("POST", "/search-reviews", {"review_token": result["review_token"], "reviewer": "Юрист", "results": []})
|
|
with self.assertRaisesRegex(ApiError, "exactly once"):
|
|
api.handle("POST", "/search-reviews", {"review_token": result["review_token"], "reviewer": "Юрист", "results": [{"rank": 1, "code": "7", "rating": 3}]})
|
|
|
|
def test_invalid_rank_types_and_sets_are_rejected_as_bad_requests(self):
|
|
with tempfile.TemporaryDirectory() as temporary:
|
|
api = Api("http://opensearch:9200", "current", Path(temporary), review_secret=b"test-secret")
|
|
response = {"hits": {"hits": [
|
|
{"_source": {"document_code": "7", "edition_code": "10", "document_name_ru": "Закон"}},
|
|
{"_source": {"document_code": "8", "edition_code": "11", "document_name_ru": "Кодекс"}},
|
|
]}}
|
|
with patch("search.api.request_json", return_value=response):
|
|
result = api.handle("GET", "/search?q=test&language=ru&page_size=2")[1]
|
|
token = result["review_token"]
|
|
|
|
malformed = [
|
|
{"rank": True, "code": "7", "rating": 3},
|
|
{"rank": [1], "code": "7", "rating": 3},
|
|
{"rank": {"value": 1}, "code": "7", "rating": 3},
|
|
{"rank": None, "code": "7", "rating": 3},
|
|
{"rank": "1", "code": "7", "rating": 3},
|
|
{"rank": 1.0, "code": "7", "rating": 3},
|
|
None,
|
|
]
|
|
for item in malformed:
|
|
with self.subTest(item=item):
|
|
with self.assertRaises(ApiError) as raised:
|
|
api.handle("POST", "/search-reviews", {"review_token": token, "reviewer": "Юрист", "results": [item]})
|
|
self.assertEqual(raised.exception.status, 400)
|
|
|
|
for submitted in (
|
|
[],
|
|
[{"rank": 1, "code": "7", "rating": 3}, {"rank": 1, "code": "7", "rating": 3}],
|
|
[{"rank": 1, "code": "7", "rating": 3}, {"rank": 3, "code": "8", "rating": 3}],
|
|
[{"rank": 1, "code": "7", "rating": 3}],
|
|
{"rank": 1, "code": "7", "rating": 3},
|
|
):
|
|
with self.subTest(submitted=submitted):
|
|
with self.assertRaises(ApiError) as raised:
|
|
api.handle("POST", "/search-reviews", {"review_token": token, "reviewer": "Юрист", "results": submitted})
|
|
self.assertEqual(raised.exception.status, 400)
|
|
|
|
oversized = [{"rank": 1, "code": "7", "rating": 3}] * 101
|
|
with self.assertRaises(ApiError) as raised:
|
|
api.handle("POST", "/search-reviews", {"review_token": token, "reviewer": "Юрист", "results": oversized})
|
|
self.assertEqual(raised.exception.status, 400)
|
|
|
|
def test_saves_signed_search_snapshot_and_rejects_tampering(self):
|
|
with tempfile.TemporaryDirectory() as temporary:
|
|
api = Api("http://opensearch:9200", "current", Path(temporary), Path(temporary) / "reviews.sqlite3", b"test-secret")
|
|
response = {"hits": {"hits": [{"_index": "search-20260827", "_source": {"document_code": "7", "edition_code": "10", "document_name_ru": "Закон"}}]}}
|
|
with patch("search.api.request_json", return_value=response):
|
|
result = api.handle("GET", "/search?q=%D0%B7%D0%B0%D0%BA%D0%BE%D0%BD&language=ru")[1]
|
|
self.assertEqual(api.review_snapshots.verify(result["review_token"])["index_name"], "search-20260827")
|
|
saved = api.handle("POST", "/search-reviews", {"review_token": result["review_token"], "reviewer": "Юрист", "results": [{"rank": 1, "code": "7", "rating": 3, "comment": "Прямой ответ"}]})
|
|
self.assertEqual(saved[0], 201)
|
|
exported = api.handle("GET", "/search-reviews/export")[1]["reviews"]
|
|
self.assertEqual(exported[0]["index_name"], "search-20260827")
|
|
self.assertEqual(exported[0]["top_result_code"], "7")
|
|
self.assertEqual(exported[0]["results"][0]["rating"], 3)
|
|
with self.assertRaisesRegex(ApiError, "does not match"):
|
|
api.handle("POST", "/search-reviews", {"review_token": result["review_token"], "reviewer": "Юрист", "results": [{"rank": 1, "code": "8", "rating": 3}]})
|
|
|
|
def test_saves_signed_empty_snapshot_with_query_level_comment(self):
|
|
with tempfile.TemporaryDirectory() as temporary:
|
|
api = Api("http://opensearch:9200", "current", Path(temporary), Path(temporary) / "reviews.sqlite3", b"test-secret")
|
|
with patch("search.api.request_json", return_value={"hits": {"hits": []}}):
|
|
result = api.handle("GET", "/search?q=редкий+запрос&language=ru")[1]
|
|
self.assertEqual(api.review_snapshots.verify(result["review_token"])["index_name"], "current")
|
|
body = {
|
|
"review_token": result["review_token"],
|
|
"reviewer": "Юрист",
|
|
"overall_comment": "Пустая выдача подтверждена.",
|
|
"results": [],
|
|
}
|
|
with self.assertRaisesRegex(ApiError, "overall_comment is required"):
|
|
api.handle("POST", "/search-reviews", {**body, "overall_comment": ""})
|
|
saved = api.handle("POST", "/search-reviews", body)
|
|
self.assertEqual(saved[0], 201)
|
|
review = api.handle("GET", "/search-reviews/export")[1]["reviews"][0]
|
|
self.assertIsNone(review["top_result_code"])
|
|
self.assertEqual(review["results"], [])
|
|
self.assertEqual(review["overall_comment"], body["overall_comment"])
|
|
|
|
def test_review_page_enables_query_level_review_for_empty_results(self):
|
|
with tempfile.TemporaryDirectory() as temporary:
|
|
api = Api("http://opensearch:9200", "current", Path(temporary))
|
|
page = api.review_page()
|
|
self.assertIn("state.results.length ? 'Сохранить оценку' : 'Сохранить пустую выдачу'", page)
|
|
self.assertIn("aria-required', String(!state.results.length)", page)
|
|
self.assertIn("const results = state.results.map((result, index) => { const item", page)
|
|
|
|
def test_snapshot_and_review_page_are_available(self):
|
|
with tempfile.TemporaryDirectory() as temporary:
|
|
api = Api("http://opensearch:9200", "current", Path(temporary))
|
|
page = api.review_page()
|
|
self.assertIn("Оценка поисковой выдачи", page)
|
|
self.assertIn("akyldash-search-review-draft", page)
|
|
self.assertIn("tutorial-dialog", page)
|
|
self.assertIn("Как это работает", page)
|
|
self.assertNotIn('id="error"', page)
|
|
self.assertIn("localStorage", page)
|
|
|
|
def test_new_search_snapshots_use_search_8_without_invalidating_search_7(self):
|
|
with tempfile.TemporaryDirectory() as temporary:
|
|
api = Api("http://opensearch:9200", "current", Path(temporary), Path(temporary) / "reviews.sqlite3", b"test-secret")
|
|
with patch("search.api.request_json", return_value={"hits": {"hits": [{"_index": "current-v2", "_source": {"document_code": "7", "document_name_ru": "Закон"}}]}}):
|
|
result = api.handle("GET", "/search?q=test&language=ru")[1]
|
|
current = api.review_snapshots.verify(result["review_token"])
|
|
self.assertEqual(SEARCH_ALGORITHM_VERSION, "search-8")
|
|
self.assertEqual(current["algorithm_version"], "search-8")
|
|
|
|
legacy_token = api.review_snapshots.create(
|
|
"legacy query", "ru", "current-v1", [{"rank": 1, "code": "7"}], "search-7"
|
|
)
|
|
legacy_saved = api.handle("POST", "/search-reviews", {
|
|
"review_token": legacy_token,
|
|
"reviewer": "Юрист",
|
|
"results": [{"rank": 1, "code": "7", "rating": 3}],
|
|
})
|
|
self.assertEqual(legacy_saved[0], 201)
|
|
exported = api.handle("GET", "/search-reviews/export")[1]["reviews"]
|
|
self.assertEqual(exported[-1]["algorithm_version"], "search-7")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|