Risk: HIGH (Windows installer and ACL security guards).
Use SID-native GetOwner/GetAccessRules calls in the Windows release installer and external backup receiver. Unknown principals remain visible to the existing fail-closed guards. Add a Windows harness that extracts and exercises the real installer guards with an unmapped synthetic SID, plus Python static regressions and CURRENT_STATE documentation.
Checks: infra/backup 45 tests passed; infra/deploy 119 tests passed; recovery host guard passed; git diff --check passed. Native PowerShell 5.1 harness could not run in this Linux environment and remains required on Windows. No host ACL, installer, VPS, or production state was changed. Changelog will follow only after initial review per repository policy.
Risk: HIGH (Windows installer and ACL security guards).
Use SID-native GetOwner/GetAccessRules calls in the Windows release installer and external backup receiver. Unknown principals remain visible to the existing fail-closed guards. Add a Windows harness that extracts and exercises the real installer guards with an unmapped synthetic SID, plus Python static regressions and CURRENT_STATE documentation.
Checks: infra/backup 45 tests passed; infra/deploy 119 tests passed; recovery host guard passed; git diff --check passed. Native PowerShell 5.1 harness could not run in this Linux environment and remains required on Windows. No host ACL, installer, VPS, or production state was changed. Changelog will follow only after initial review per repository policy.
Reviewed the complete six-file diff at 3d7df25d00. ACL owners and all explicit/inherited ACEs are read as SIDs; unmapped principals remain subject to the existing fail-closed checks. CI runs 728/729 and the exact-hash ordinary Windows PowerShell 5.1 native bundle-mode harness passed. No deployment or host change is covered by this approval.
Reviewed the complete six-file diff at 3d7df25d008b5a293ef71bd094b2b38b1d39359e. ACL owners and all explicit/inherited ACEs are read as SIDs; unmapped principals remain subject to the existing fail-closed checks. CI runs 728/729 and the exact-hash ordinary Windows PowerShell 5.1 native bundle-mode harness passed. No deployment or host change is covered by this approval.
Review complete for head 3d7df25d00: raw-SID owner and ACE enumeration preserves the existing fail-closed ACL policy, including unmapped principals. CI runs 728/729 and the exact-hash ordinary Windows PowerShell 5.1 native bundle-mode harness passed. Formal APPROVED review: #392. No merge, installer, host ACL change, or deployment is covered by this review.
Review complete for head 3d7df25d008b5a293ef71bd094b2b38b1d39359e: raw-SID owner and ACE enumeration preserves the existing fail-closed ACL policy, including unmapped principals. CI runs 728/729 and the exact-hash ordinary Windows PowerShell 5.1 native bundle-mode harness passed. Formal APPROVED review: #392. No merge, installer, host ACL change, or deployment is covered by this review.
Full final review at 5c26bbe8b5: the six previously reviewed executable/test/document files are byte-identical to approved 3d7df25d; the only new change is the accurate six-line changelog entry. Raw SID ACL guards retain fail-closed checks. CI 730/731 and exact-hash native Windows PowerShell 5.1 harness passed. No findings.
Full final review at 5c26bbe8b534faa28a4299f5e0861cbfc554328c: the six previously reviewed executable/test/document files are byte-identical to approved 3d7df25d; the only new change is the accurate six-line changelog entry. Raw SID ACL guards retain fail-closed checks. CI 730/731 and exact-hash native Windows PowerShell 5.1 harness passed. No findings.
agent
merged commit 871bde1abd into main2026-11-03 09:11:41 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
agent
Risk: HIGH (Windows installer and ACL security guards).
Use SID-native GetOwner/GetAccessRules calls in the Windows release installer and external backup receiver. Unknown principals remain visible to the existing fail-closed guards. Add a Windows harness that extracts and exercises the real installer guards with an unmapped synthetic SID, plus Python static regressions and CURRENT_STATE documentation.
Checks: infra/backup 45 tests passed; infra/deploy 119 tests passed; recovery host guard passed; git diff --check passed. Native PowerShell 5.1 harness could not run in this Linux environment and remains required on Windows. No host ACL, installer, VPS, or production state was changed. Changelog will follow only after initial review per repository policy.
Reviewed the complete six-file diff at
3d7df25d00. ACL owners and all explicit/inherited ACEs are read as SIDs; unmapped principals remain subject to the existing fail-closed checks. CI runs 728/729 and the exact-hash ordinary Windows PowerShell 5.1 native bundle-mode harness passed. No deployment or host change is covered by this approval.Review complete for head
3d7df25d00: raw-SID owner and ACE enumeration preserves the existing fail-closed ACL policy, including unmapped principals. CI runs 728/729 and the exact-hash ordinary Windows PowerShell 5.1 native bundle-mode harness passed. Formal APPROVED review: #392. No merge, installer, host ACL change, or deployment is covered by this review.New commits pushed, approval review dismissed automatically according to repository settings
Full final review at
5c26bbe8b5: the six previously reviewed executable/test/document files are byte-identical to approved 3d7df25d; the only new change is the accurate six-line changelog entry. Raw SID ACL guards retain fail-closed checks. CI 730/731 and exact-hash native Windows PowerShell 5.1 harness passed. No findings.